-
Notifications
You must be signed in to change notification settings - Fork 66
feat: v1 NXM push #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: v1 NXM push #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
cbc935d
to
40d5d54
Compare
There are quite a few scripts here but these are the ones that will execute the push:
Please prioritise these files in the review. |
62f7f8a
to
2c1d237
Compare
2c1d237
to
49f34e8
Compare
Execution PlanIt's best to run the script on one of our machines as it will be a long running process (waiting for gas fees to be favourable before executing txs)
|
shark0der
reviewed
Sep 5, 2024
58e62a7
to
e464a35
Compare
4c7306d
to
42e5941
Compare
6653705
to
ad17a34
Compare
closing ticket as its a one time execution. will keep the branch if for some reason we need the scripts in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #1215
NOTE:
Not sure we should merge this as the code will only be used once. We can keep the branch to refer to it later if need be.
Scripts to find out v1 nxm details, accounting, gas estimates as well as v1 nxm push scripts
Account to execute txs:
Changes proposed in this pull request
v1 NXM push (the scripts that will be use for executing the push)
v1 NXM details:
Estimate gas:
Test plan
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: