Skip to content

Conversation

shark0der
Copy link
Contributor

Context

Include relevant motivation and context. A link to the issue is enough if it contains all the relevant
information.

Changes proposed in this pull request

Include a summary of the change.

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@shark0der shark0der added this pull request to the merge queue Sep 19, 2024
@shark0der shark0der disabled auto-merge September 19, 2024 13:28
@shark0der shark0der merged commit 09c588b into test-release-candidate Sep 19, 2024
6 checks passed
@shark0der shark0der deleted the feature/test-feature branch September 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants