Skip to content

Conversation

MilGard91
Copy link
Contributor

Context

Include relevant motivation and context. A link to the issue is enough if it contains all the relevant
information.

Changes proposed in this pull request

Include a summary of the change.

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 force-pushed the audit/long-term-limit-order-fixes branch from a86add1 to 6fd4968 Compare September 20, 2024 14:13
@MilGard91 MilGard91 requested a review from shark0der September 20, 2024 14:13
@MilGard91 MilGard91 marked this pull request as ready for review September 20, 2024 14:13
@MilGard91 MilGard91 force-pushed the audit/long-term-limit-order-fixes branch from 6fd4968 to 256c64c Compare September 20, 2024 14:23
@MilGard91 MilGard91 force-pushed the audit/long-term-limit-order-fixes branch from 256c64c to c5021ce Compare September 20, 2024 14:46
@MilGard91 MilGard91 merged commit c5021ce into audit/long-term-limit-order Sep 23, 2024
6 checks passed
@MilGard91 MilGard91 deleted the audit/long-term-limit-order-fixes branch September 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants