feat: cover ri pool #1464
Open
feat: cover ri pool #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shark0der
force-pushed
the
feat/cover-ri-pool
branch
from
533117f to
587d1cd
Compare
rackstar
reviewed
Oct 2, 2025
test/unit/Cover/setup.js
Outdated
| config.chainId = (await signer.provider.getNetwork()).chainId; | ||
| } | ||
|
|
||
| const verifier = await getAddress(verifyingContract); |
There was a problem hiding this comment.
Initially I wrote it with the idea that you can pass a signer too, but now that you mention this, it makes sense to have support for contracts only, so I'll use .target, thanks
There was a problem hiding this comment.
Added .target with a fallback to using the variable as is in case an address (string) is passed.
rackstar
reviewed
Oct 2, 2025
MilGard91
reviewed
Oct 3, 2025
shark0der
force-pushed
the
feat/cover-ri-pool
branch
from
afd8530 to
7d55885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made in this PR. A link to the issue is enough if it contains all the relevant information.
Testing
Explain how you tested your changes to ensure they work as expected.
Checklist