test: migrate Cover integration tests to ethers v6 #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackstar
commented
Sep 30, 2025
Comment on lines
+1
to
+13
| /** | ||
| * Division with ceiling rounding - equivalent to Math.ceil(a / b) for BigInt | ||
| */ | ||
| function divCeil(a, b) { | ||
| return (a + b - 1n) / b; | ||
| } | ||
|
|
||
| /** | ||
| * Get minimum of two BigInt values | ||
| */ | ||
| function min(a, b) { | ||
| return a < b ? a : b; | ||
| } |
There was a problem hiding this comment.
this file is deprecated in the next PR in favour of BigIntMath in lib/helpers.js (didnt noticed that file until the next PR)
rackstar
force-pushed
the
test/cover-integration-ethers-v6
branch
2 times, most recently
from
19bee83 to
6cf2888
Compare
2 tasks
* fix coverNFTDescriptor constructor args * fix pool asset ordering
shark0der
force-pushed
the
test/cover-integration-ethers-v6
branch
from
6cf2888 to
16c491f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1466
migrate Cover integration tests to ethers v6
Testing
Checklist