Feature/extra cover tests #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| function performPayoutBurn( | ||
| function performStakeBurn( |
There was a problem hiding this comment.
What's the rationale behind this rename? Isn't "burnAmount" supposed to be the amount paid out (i.e. ETH/DAI, not NXM)? It definitely isn't the stake (in NXM) that is burned and we don't necessarily burn NXM when we make a payout, that's just a consequence of the payout.
There was a problem hiding this comment.
Discussed off-band.
roxdanila
reviewed
Jun 9, 2022
| BuyCoverParams memory buyCoverParams, | ||
| PoolAllocationRequest[] memory poolAllocations | ||
| ) external payable onlyMember whenNotPaused { | ||
| ) external payable onlyMember whenNotPaused nonReentrant { |
There was a problem hiding this comment.
remove the require below:
require(lastCoverSegment.start + lastCoverSegment.period > block.timestamp, "Cover: cover expired");
There was a problem hiding this comment.
removed.
Changed condition in the IF to check for that.
…art-contracts into feature/extra-cover-tests
roxdanila
approved these changes
Jun 12, 2022
roxdanila
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.