Skip to content

Feature: staking v2 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Sep 26, 2022
Merged

Feature: staking v2 #261

merged 25 commits into from
Sep 26, 2022

Conversation

shark0der
Copy link
Contributor

No description provided.

@shark0der shark0der marked this pull request as ready for review September 16, 2022 09:05
roxdanila
roxdanila previously requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@roxdanila roxdanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing github filters

@shark0der shark0der requested a review from roxdanila September 16, 2022 09:06
roxdanila
roxdanila requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@roxdanila roxdanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moar testing

@shark0der shark0der requested a review from roxdanila September 16, 2022 09:09
roxdanila
roxdanila requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@roxdanila roxdanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last test

@shark0der
Fix extendDeposit issues and optimize gas usage
26f4eaf
@shark0der
Fix minted tokenId and deposit save location in depositTo
af074ef
@shark0der
Remove redundant comments
3a949a6
@shark0der
Fix stack too deep in depositTo
a4c366b
@shark0der
Fix excessive withdrawals in withdraw
426d8cf
@shark0der
Fix reward calculation bug in setPoolFee
0b142db
@shark0der
Fix newCoverAmount by adding a typecast before the bit shift
b99cda5
@shark0der
Fix bit shift direction in getItemAt
5497ed0
@shark0der
Fix type casting order in CoverAmountGroup.setItemAt
8b21bba
@shark0der
Fix bit shift direction in BucketTrancheGroup.getItemAt
cf98c6f
@shark0der
Fix mask and itemUnderlying calculation in BucketTrancheGroup.setItemAt
e52d3ba
@shark0der
Fix packedCoverTrancheAllocation bit shift operations
89276c1
@shark0der
Fix initial deposit reverting when a private pool is created
2b8dbcc
@shark0der
Remove the _ prefix from isApprovedOrOwner and move below initialize()
10492a6
@shark0der
Rename argument to prevent shadowing
1d375b3
@shark0der
Fix incorrect storage location for name and symbol issue
ad11869
@shark0der
Add back the accidentally removed isApprovedOrOwner
8c8bc60
@shark0der
Fix StakingPool constructor args in unit tests
367f285
@shark0der
Remove unused mock NFT and fix tokenURI warning
e3d1099
@shark0der shark0der requested a review from 0xdewy September 26, 2022 11:48
roxdanila
roxdanila approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@roxdanila roxdanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this as is, so we don't block ourselves on new PRs

@shark0der shark0der merged commit a75ff74 into nexus-v2 Sep 26, 2022
@shark0der shark0der deleted the feature/staking-v2 branch September 26, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxdanila roxdanila roxdanila approved these changes

@0xdewy 0xdewy Awaiting requested review from 0xdewy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shark0der @roxdanila