-
Notifications
You must be signed in to change notification settings - Fork 66
Chore: Upgrade hardhat to v2.11 #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdewy
commented
Sep 9, 2022
shark0der
requested changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure typechain works, remove custom typechain task, switch to config
shark0der
reviewed
Sep 13, 2022
hardhat.config.js/index.js
Outdated
Comment on lines
25
to
28
outDir: 'src/types', | ||
target: 'ethers-v5', | ||
alwaysGenerateOverloads: false, | ||
externalArtifacts: ['externalArtifacts/*.json'], | ||
dontOverrideCompile: true, // defaults to false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outDir
should be'types'
(drop thesrc/
)- we currently don't have external artifacts, remove that line. if we want it - let's do another PR as it's a new feature that's out of scope for this one
24168fe
to
73c71ff
Compare
73c71ff
to
695f3f5
Compare
shark0der
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
closes #359
Changes proposed in this pull request
This PR upgrades hardhat and solidity-coverage to the latest releases. This PR also changed the
typechain
dependency to the hardhat native@typechain/hardhat
, as well as update@typechain/truffle-v5
.Test plan
No further tests were added