Skip to content

Conversation

0xdewy
Copy link
Contributor

@0xdewy 0xdewy commented Sep 9, 2022

Context

closes #359

Changes proposed in this pull request

This PR upgrades hardhat and solidity-coverage to the latest releases. This PR also changed the typechain dependency to the hardhat native @typechain/hardhat, as well as update @typechain/truffle-v5.

Test plan

No further tests were added

Copy link
Contributor

@shark0der shark0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure typechain works, remove custom typechain task, switch to config

@0xdewy 0xdewy requested a review from shark0der September 13, 2022 09:36
Comment on lines 25 to 28
outDir: 'src/types',
target: 'ethers-v5',
alwaysGenerateOverloads: false,
externalArtifacts: ['externalArtifacts/*.json'],
dontOverrideCompile: true, // defaults to false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • outDir should be 'types' (drop the src/)
  • we currently don't have external artifacts, remove that line. if we want it - let's do another PR as it's a new feature that's out of scope for this one

@0xdewy 0xdewy force-pushed the chore/upgrade_hardhat branch 2 times, most recently from 24168fe to 73c71ff Compare September 13, 2022 11:55
@0xdewy 0xdewy force-pushed the chore/upgrade_hardhat branch from 73c71ff to 695f3f5 Compare September 13, 2022 12:31
@shark0der shark0der merged commit 1c0562b into nexus-v2 Sep 13, 2022
@shark0der shark0der deleted the chore/upgrade_hardhat branch September 13, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants