Skip to content

Feature/Add unit tests for withdrawRewardsTo #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2022
Merged

Feature/Add unit tests for withdrawRewardsTo #404

merged 2 commits into from
Oct 5, 2022

Conversation

0xdewy
Copy link
Contributor

@0xdewy 0xdewy commented Oct 4, 2022

Context

Closes #337 Assessment unit tests

Changes proposed in this pull request

This PR adds more unit tests for the withdrawRewardsTo() function.

Test plan

More tests were added in test/unit/Assessment/withdrawRewardsTo.js

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

roxdanila
roxdanila approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@roxdanila roxdanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xdewy 0xdewy force-pushed the feature/assessment-unit-tests branch from 906a386 to f72ce31 Compare October 5, 2022 07:42
@0xdewy 0xdewy linked an issue Oct 5, 2022 that may be closed by this pull request
Assessment unit tests: withdrawRewards #337
Closed
7 tasks
@roxdanila roxdanila merged commit 3be4804 into nexus-v2 Oct 5, 2022
@roxdanila roxdanila deleted the feature/assessment-unit-tests branch October 5, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxdanila roxdanila roxdanila approved these changes

@danoctavian danoctavian Awaiting requested review from danoctavian

@shark0der shark0der Awaiting requested review from shark0der

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assessment unit tests: withdrawRewards
2 participants
@0xdewy @roxdanila