Fix: update tranches not performing any updates #406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #299
When the pool is new, the function was always skipping the updates, never updating any value. Because of this early exit the function was never updating anything.
Changes proposed in this pull request
The new implementation will stil exit early without updating anything if a forced update was not requested (
updateUntilCurrentTimestamp = true
). A force update should be requested if the function callingupdateTranches
changes the share supply. If the share supply is not being changed - we should be fine skipping the update i.e. avoid any writes.I'm not entirely sure there aren't any edge cases that I didn't account for. Please review carefully.
Test plan
No tests present for staking at the moment.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: