Use v1 cover sumAssured as it is (already in wei) #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The cover migrate transaction for a v1 cover got reverted with reason string
SafeCast: value doesn't fit in 96 bits
on the amount param.Changes proposed in this pull request
I noticed that the
sumAssured
value of a v1 cover (at runtime) was already in wei (had 18 0s) so there was no need to convert it further. The change in this PR removes that conversion.Test plan
I've only tested it locally, using the deploy script and calling the migrate contract method from the FE app. With this change, the v1 cover gets migrated successfully.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: