Skip to content

Conversation

mixplore
Copy link
Contributor

@mixplore mixplore commented Oct 21, 2022

Context

The cover migrate transaction for a v1 cover got reverted with reason string SafeCast: value doesn't fit in 96 bits on the amount param.

Changes proposed in this pull request

I noticed that the sumAssured value of a v1 cover (at runtime) was already in wei (had 18 0s) so there was no need to convert it further. The change in this PR removes that conversion.

Test plan

I've only tested it locally, using the deploy script and calling the migrate contract method from the FE app. With this change, the v1 cover gets migrated successfully.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@shark0der
Copy link
Contributor

N/A

@shark0der shark0der closed this Oct 21, 2022
@roxdanila roxdanila deleted the fix/cover-migration-amount-error branch May 16, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants