Test: Add createStakingPool and performStakeBurn unit tests #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
danoctavian
force-pushed
the
test/cover-create-pool-stake-burn-unit-tests
branch
from
3914e81 to
4a80f41
Compare
danoctavian
reviewed
Nov 1, 2022
test/unit/Cover/helpers.js
Outdated
| return buyCoverOnMultiplePools.call(this, params, 1); | ||
| } | ||
|
|
||
| async function buyCoverOnMultiplePools( |
There was a problem hiding this comment.
this is not clear enough what it does.
It both create pools and buys.
Also it's used in only 1 place.
Let's have a function that's buyCoverOnMultiplePools
but creates the pools before separately. There's only 1 place where this is used.
There was a problem hiding this comment.
I'm not sure I fully understood your proposed changes. I applied the following changes 132e088 to only buy the cover on buyCoverOnMultiplePools and creating the pools outside the function, in the test that uses it and in buyCoverOnOnePool to not modify the behavior of that function as it is used in several unit tests.
Is something like this what you had in mind?
There was a problem hiding this comment.
This is what i mean yes, good!
danoctavian
approved these changes
Nov 1, 2022
danoctavian
suggested changes
Nov 1, 2022
roxdanila
force-pushed
the
test/cover-create-pool-stake-burn-unit-tests
branch
from
132e088 to
95a0e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #274
Changes proposed in this pull request
Adds new unit tests for
createStakingPoolandperformStakeBurn. Implemented the list of test cases from the issue.Test plan
New tests were added in
test/unit/Cover/createStakingPool.jsandtest/unit/Cover/performStakeBurn.jsChecklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: