Skip to content

Conversation

shark0der
Copy link
Contributor

@shark0der shark0der commented Nov 3, 2022

Context

Several test setup improvements to keep things clean.

Changes proposed in this pull request

  • Removes hardcoded berlin hardfork and fixes the tests that failed due to zero gas fee txes
  • Simplifies accounts and signers generation and usage

Test plan

Only existing tests needed to pass.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@shark0der shark0der force-pushed the chore/tests-housekeeping branch from 94cc491 to 69e5a6d Compare November 3, 2022 15:23
@roxdanila roxdanila force-pushed the chore/tests-housekeeping branch from 69e5a6d to 9c3b16a Compare November 3, 2022 16:38
@roxdanila roxdanila force-pushed the chore/tests-housekeeping branch from 9c3b16a to ad61855 Compare November 9, 2022 13:38
@roxdanila roxdanila merged commit be30230 into nexus-v2 Nov 10, 2022
@roxdanila roxdanila deleted the chore/tests-housekeeping branch November 10, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants