Test/cover constructor initialization #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paterson1
requested review from
shark0der,
danoctavian,
patitonar and
roxdanila
danoctavian
reviewed
Nov 7, 2022
| }); | ||
|
|
||
| const cover = await Cover.deploy( | ||
| quotationData.address, |
There was a problem hiding this comment.
these values
quotationData.address
productsV1.address
are private fields. However we can try using getStorageAt https://docs.ethers.io/v5/api/providers/provider/#Provider-getStorageAt
to get the field value.
Let's try asserting them regardless using getStorageAt
There was a problem hiding this comment.
I've tried with hardhat-storage-layout and couldn't find them, and then I realized that they are immutable so they are not saved to storage
There was a problem hiding this comment.
Ah yes. You're right they are not in storage they are in contract code.
Ok this is fine for now
danoctavian
reviewed
Nov 7, 2022
| this.quotationData = quotationData; | ||
| this.stakingPool = stakingPool; | ||
| this.coverAddress = coverAddress; | ||
| this.futureCoverNFTAddress = futureCoverNFTAddress; |
There was a problem hiding this comment.
can add a dummy productsV1 address here.
danoctavian
suggested changes
Nov 7, 2022
|
Needs rebase. |
roxdanila
force-pushed
the
test/cover-constructor-initialization
branch
from
ba14d59 to
087db68
Compare
4 tasks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #282
Changes proposed in this pull request
Added tests for the constructor and initialize functions of
Cover.sol.setupwas changed to expose some values to make it easier to deploy a newCovernot initialized.Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: