Test: Add Cover YieldTokenIncidents claim integration tests #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoctavian
force-pushed
the
test/cover-yieldtokenincidents-integration-tests
branch
from
0ec6010 to
3ee311e
Compare
danoctavian
reviewed
Dec 7, 2022
| [chainlinkDAI.address, chainlinkSteth.address], | ||
| [18, 18], | ||
| [dai.address, stETH.address, usdc.address], | ||
| [chainlinkDAI.address, chainlinkSteth.address, chainlinkUSDC.address], |
There was a problem hiding this comment.
good integration test addition for USDC to test different decimals basically
danoctavian
reviewed
Dec 7, 2022
|
|
||
| const { period, gracePeriod, priceDenominator } = submitClaimFixture; | ||
|
|
||
| const amount = parseUnits('10', 6); |
danoctavian
reviewed
Dec 7, 2022
| }); | ||
|
|
||
| // submit incident | ||
| await submitIncident({ gv, yc, productId, period, priceBefore: parseUnits('1', 6) }); |
danoctavian
reviewed
Dec 7, 2022
| yc.connect(coverBuyer1).redeemPayout(0, 0, 0, parseEther('1'), nonMember1.address, [], { gasPrice: 0 }), | ||
| ).to.be.revertedWith('The incident needs to be accepted'); | ||
| const usdcBalanceBefore = await usdc.balanceOf(nonMember1.address); | ||
| await yc.connect(coverBuyer1).redeemPayout(0, 0, 0, parseUnits('1', 6), nonMember1.address, []); |
There was a problem hiding this comment.
const usdcDecimals all over there's a few more places
|
This looks good, just a few minor things but they are not critical @patitonar |
danoctavian
deleted the
test/cover-yieldtokenincidents-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #326
Changes proposed in this pull request
Adds new integration tests for the process of submitting a claim and redeeming the payout.
Test plan
New tests were added in
test/integration/YieldTokenIncidents/submitClaim.jsChecklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: