Skip to content

Conversation

shark0der
Copy link
Contributor

@shark0der shark0der commented Dec 13, 2022

Changes proposed in this pull request

  • Add a few todos for bugs and missing implementations
  • Remove unused variable
  • Fix missing parens caught by audit

Test plan

Added todos have corresponding issues and will be tested when implemented.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@roxdanila roxdanila force-pushed the chore/small-fixes-and-todo-comments branch from cf736ca to 81cecf3 Compare December 13, 2022 22:06
Copy link
Contributor

@roxdanila roxdanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shark0der shark0der merged commit 5cf8a40 into nexus-v2 Dec 14, 2022
@shark0der shark0der deleted the chore/small-fixes-and-todo-comments branch December 14, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants