Skip to content

Conversation

mixplore
Copy link
Contributor

@mixplore mixplore commented Dec 13, 2022

Context

Needed to update the deploy script to work with the latest contracts changes.
For claims details on FE side, we need the assessmentId field returned as well for querying the voting details (using getPoll method).

Changes proposed in this pull request

  • added the asssessmentId field to claim details returned view
  • updated params for products and staking pool creation in deploy script and mock script

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@mixplore mixplore requested a review from roxdanila December 13, 2022 17:12
@mixplore mixplore self-assigned this Dec 13, 2022
@mixplore mixplore force-pushed the feat/updates-for-fe-support branch from 8428c0b to 8267015 Compare December 13, 2022 17:17
@mixplore mixplore merged commit faae180 into nexus-v2 Dec 13, 2022
@mixplore mixplore deleted the feat/updates-for-fe-support branch December 13, 2022 17:26
productType: {
descriptionIpfsHash: 'yieldTokenCoverIPFSHash',
claimMethod: claimMethod.incident,
gracePeriodInDays: 14,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mixplore I think the new gracePeriod param is now in seconds, not in days anymore - @shark0der ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants