Skip to content

Conversation

danoctavian
Copy link
Contributor

@danoctavian danoctavian commented Dec 14, 2022

Context

Fix small issues with deploy.js

Changes proposed in this pull request

Use DisposableAssesment and whitelist Assessment so it can receive NXM + deploy.js fix.

Test plan

Existing tests pass + deploy.js on local network finishes successfully with command

ABI_DIR=../frontend-react/src/constants/abis CONFIG_FILE=../frontend-react/config/local.json node scripts/deploy/start.j

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@danoctavian danoctavian marked this pull request as ready for review December 14, 2022 16:00
Copy link
Contributor

@mixplore mixplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danoctavian danoctavian merged commit 44250ae into nexus-v2 Dec 15, 2022
@danoctavian danoctavian deleted the fix/assessment-deploy branch December 15, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants