Skip to content

Conversation

roxdanila
Copy link
Contributor

Context

Found it really tricky to navigate the contract as I was reviewing emergency pause usage.

Changes proposed in this pull request

Grouped functions together in the following categories, for easier navigation:

  • CONSTRUCTOR
  • WHITELIST RELATED MUTATIVE FUNCTIONS
  • TOKEN RELATED VIEW FUNCTIONS
  • INTERNAL OPERATOR RELATED MUTATIVE FUNCTIONS
  • USER REWARDS RELATED MUTATIVE FUNCTIONS
  • V1 RELATED VIEW FUNCTIONS
  • V1 RELATED MUTATIVE FUNCTIONS
  • DEPENDENCIES

This is what made sense to me without spending too much time on it. I hope this won't stir an opinionated debate, but if think something doesn't make sense, let me know.

Test plan

Existing tests pass.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@shark0der shark0der changed the base branch from master to nexus-v2 January 6, 2023 17:09
@shark0der shark0der marked this pull request as draft January 6, 2023 17:44
@shark0der
Copy link
Contributor

Will conflict with feature/staking-nft. Let's rebase it after that one is merged.

@roxdanila roxdanila changed the base branch from nexus-v2 to feature/staking-nft January 6, 2023 18:07
@shark0der shark0der force-pushed the feature/staking-nft branch from ec72203 to c771568 Compare January 9, 2023 11:22
@roxdanila
Copy link
Contributor Author

Closing in favour of #611

@roxdanila roxdanila closed this Jan 9, 2023
@roxdanila roxdanila deleted the chore/tc-cleanup branch May 16, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants