Chore: Gateway cleanup #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxdanila
changed the base branch from
master
to
feature/staking-nft-contracts
shark0der
force-pushed
the
chore/gatway-cleanup
branch
from
363c011 to
93d4685
Compare
danoctavian
reviewed
Jan 11, 2023
| // which occupies 2 slots instead of 1. | ||
| // address public _unused_quotation; | ||
|
|
||
| address public _unused_nxmToken; |
There was a problem hiding this comment.
we've usually been naming them with numbers
but i don't see any issue with this, it's actually self-documenting, seems better
danoctavian
reviewed
Jan 11, 2023
| } else { | ||
| status = ClaimStatus.IN_PROGRESS; | ||
| } | ||
| function initializeDAI() external { |
There was a problem hiding this comment.
do we still need this function? DAI is initialized
danoctavian
reviewed
Jan 11, 2023
| address public _unused_memberRoles; | ||
|
|
||
| // assigned in initialize | ||
| address public DAI; |
There was a problem hiding this comment.
Note: We will need to verify storage slots on the fork
@MilGard91 once this is merged.
Based on visual inspection, looks correct.
shark0der
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes issue #620
Changes proposed in this pull request
Test plan
Ran existing tests suite
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: