Skip to content

Conversation

mixplore
Copy link
Contributor

@mixplore mixplore commented Jan 16, 2023

Context

Needed for FE dev: https://github.com/NexusMutual/frontend-react/issues/781

Changes proposed in this pull request

  • removed old script for creating staking pools
  • added a new mock script for creating 2 staking pools and deposit to each

Test plan

With local deployment running, run HARDHAT_NETWORK=localhost node scripts/mocks/createStakingPools.js.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@mixplore mixplore self-assigned this Jan 16, 2023
@roxdanila roxdanila force-pushed the feat/create-staking-pools-mock-script branch from f39f162 to 6a4a08a Compare January 16, 2023 10:41
@mixplore mixplore merged commit 3d61c32 into nexus-v2 Jan 16, 2023
@mixplore mixplore deleted the feat/create-staking-pools-mock-script branch January 16, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants