Feature/v2 migration claim assessment migration #635
Conversation
| coverNotesSum: coverNotesSum.toString(), | ||
| }); | ||
|
|
||
| // TODO: this does NOT pass. Find out where the extra 7k tokens is from. |
There was a problem hiding this comment.
Proposal:
Merge this as is.
Finish up staking migration to wrap all aspects up and clear all unknowns, then get back to this issue.
The fact that there's extra tokens makes it less bad than the situation when tokens would be missing.
| console.log({ | ||
| governanceRewardsMigrated: governanceRewardsMigrated.toString(), | ||
| }); | ||
| // expect(governanceRewardsMigrated).to.be.equal(this.governanceRewardsSum); |
There was a problem hiding this comment.
There is a discrepancy here as well on the side of excess tokens. by a slight amount.
-1106654884061072517264
+870391213513961173071
Extra tokens:
236.26367054711136 NXM
danoctavian
force-pushed
the
feature/v2-migration-fork-test
branch
from
54f7e01 to
dc2c977
Compare
danoctavian
changed the base branch from
feature/v2-migration-fork-test
to
nexus-v2
danoctavian
force-pushed
the
feature/v2-migration-claim-assessment-migration
branch
from
fb54e9f to
057ee27
Compare
scripts/get-governance-rewards.js
Outdated
| process.exit(1); | ||
| }); | ||
| if (require.main === module) { | ||
| const provider = new ethers.providers.JsonRpcProvider(process.env.PROVIDER_URL); |
There was a problem hiding this comment.
Let's import ethers from hardhat and here and pass ethers.provider to the function instead - this would make the script "hardhat compatible" as you'd be able to hh run --network somenetwork scripts/get-governance-rewards.js. As a side note, the reason this function accepts a provider instead of using ethers.provider directly is because you'd be able to pass a direct provider, for example from a fork test. Currently the skipped test inside the fork passes ethers.provider which is not the intended use of the function.
|
|
…o print out token balances
danoctavian
force-pushed
the
feature/v2-migration-claim-assessment-migration
branch
from
64dc2a5 to
0b543a9
Compare
|
reran after rebase and WETH update.
|
danoctavian
deleted the
feature/v2-migration-claim-assessment-migration
branch
Context
Issue
#607
#592
Changes proposed in this pull request
Enable the steps of the fork test that transfer governance rewards out to owners, process the claim assesment staked tokens for all assessors and send them to the owners with a permisionless call and measures that expected token balances are in the right amount.
Fix memory layout for TokenController.
Fix ability to receive NXM tokens through operator transfer for TokenController.
add script to measure all withdrawable cover notes to account for tokens present in TokenController.
scripts/get-withdrawable-cover-notes.js
Test plan
The ticket concerns the fork test in itself, no other testing is required.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: