Skip to content

Conversation

patitonar
Copy link
Contributor

Context

Partial implementation of #346

Built on top of #684 to avoid conflicts in the setup

Changes proposed in this pull request

Adds new unit tests for:

  • changeOperator()
  • operatorTransfer()
  • mint()
  • burnFrom()

Test plan

New tests were added:

  • test/unit/TokenController/changeOperator.js
  • test/unit/TokenController/operatorTransfer.js
  • test/unit/TokenController/mint.js
  • test/unit/TokenController/burnFrom.js

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@patitonar patitonar changed the title Test/token controller operator unit tests Test: Add TokenController operator related methods unit tests Feb 3, 2023
@patitonar patitonar changed the title Test: Add TokenController operator related methods unit tests Test: Add token controller operator related methods unit tests Feb 3, 2023
Base automatically changed from test/token-controller-pool-unit-tests to nexus-v2 February 6, 2023 10:19
@roxdanila roxdanila force-pushed the test/token-controller-operator-unit-tests branch from d1111c9 to 6d348a5 Compare February 6, 2023 10:19
@roxdanila roxdanila linked an issue Feb 6, 2023 that may be closed by this pull request
21 tasks
@roxdanila roxdanila merged commit 60e0f2c into nexus-v2 Feb 6, 2023
@roxdanila roxdanila deleted the test/token-controller-operator-unit-tests branch February 6, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TokenController unit tests: Increase coverage
2 participants