Skip to content

Conversation

roxdanila
Copy link
Contributor

@roxdanila roxdanila commented Feb 7, 2023

Context

Include relevant motivation and context. A link to the issue is enough if it contains all the relevant
information.

Changes proposed in this pull request

Include a summary of the change.

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@roxdanila roxdanila requested a review from shark0der February 7, 2023 08:25
@roxdanila roxdanila changed the base branch from master to release-candidate February 7, 2023 08:25
@shark0der shark0der merged commit 07a73b4 into release-candidate Feb 7, 2023
@shark0der shark0der deleted the fix/reject branch February 7, 2023 10:53
@shark0der shark0der changed the title RejectAction improvement ActionFailed improvement Feb 7, 2023
@roxdanila roxdanila linked an issue Feb 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ActionFailed behaviour
2 participants