Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Branding #112

Closed
wants to merge 4 commits into from
Closed

Customizable Branding #112

wants to merge 4 commits into from

Conversation

hellfirehd
Copy link
Contributor

I needed this for my project. Thought I would share it with you to see what you think of it.

@Nfactor26
Copy link
Owner

Appreciate the PR. I will take a look as soon as I can.
Thanks.

@hellfirehd
Copy link
Contributor Author

Oops. Sorry. I do not know why it automatically pulled in my latest change. Not sure how to back it out.

@@ -7,11 +7,11 @@

namespace Pixel.Identity.UI.Client.Pages.Account
{
public partial class Logins : ComponentBase
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to rename it given this page is used to manage external logins ? Should the file name be changed instead to Logins.* ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it does not handle external logins, it shows the change password form.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply put it allows to manage your logins. If there is no external logins setup, it will let you manage your password for local account login.

@@ -10,10 +12,10 @@
<MudIconButton Icon="@Icons.Material.Outlined.Menu" Color="Color.Inherit" OnClick="@((e) => DrawerToggle())" />
</MudToolBar>
<MudHidden Breakpoint="Breakpoint.Xs">
<MudText Typo="Typo.h6" Class="ml-4">Pixel Identity</MudText>
<MudText Typo="Typo.h6" Class="ml-4">@_brand.Name</MudText>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it is possible to separate header in to a component and allow users to setup a custom one which can be loaded dynamically at runtime (e.g. by mounting a path on container). Also, the logos are not plugged in yet and would require them to be hosted somewhere else.
I will try to explore this a little.

@Nfactor26
Copy link
Owner

Oops. Sorry. I do not know why it automatically pulled in my latest change. Not sure how to back it out.

you can revert your last commit and push again.

@hellfirehd hellfirehd closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants