Lerna bootstrap peerDep warnings #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause yarn/lerna cant... kinda. - Running `lerna bootstrap` no longer produces any peer dependency warnings. - Update jest-example to support TypeScript 4.x
NiGhTTraX
added a commit
that referenced
this pull request
Apr 28, 2021
This silences the yarn warning for missing peer dependency for `@nighttrax/components`. This is actually a bug in yarn: yarnpkg/yarn#5810. I don't particularly like the workaround, but better than a noisy warning, I guess? Fixes #60.
|
Hey @cassler, thanks for sending this. I agree with the idea of removing the warnings, but we can actually declare the dependencies in the packages that need them. This also bodes well for projects using Unfortunately, due to a yarn bug, I had to declare React in the root because it's a peer dependency of the
|
NiGhTTraX
added a commit
that referenced
this pull request
Jan 24, 2022
This reverts the workarounds for #159, #74 and #60, as they are no longer needed. There are a few peer dependency warnings, though the examples work just fine: - The one for NextJS is tracked in vercel/next.js#31887. - CRACO support for CRA@5 is tracked in dilanx/craco#378. - The warnings for CRA are tracked in facebook/create-react-app#11982, except for the `ts-jest` one which is expected, since we're using CRA's `jest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this repository is intended for reliable autocompletion between packages, it would seem reasonable to include certain peer dependencies needed to ensure compatibility. You'll notice that we don't indicate a version number - as this is ostensibly to suppress warnings from
yarn.The notion here is that we'll prefer flexibility when dropping in additional packages over succinctness. Likewise, we prefer a warning-free experience out of the box. Ultimately this is only useful because of a shortcoming in
yarnfor peerDependencies which was solved in npm7Changes:
lerna bootstrapno longer produces any peer dependency warnings.