-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing peerDependency "@babel/core@^7.0.0-0" from next > styled-jsx > @babel/plugin-syntax-jsx@7.14.5 #31887
Labels
good first issue
Easy to fix issues, good for newcomers
Comments
timneutkens
added
area: styled-jsx
good first issue
Easy to fix issues, good for newcomers
and removed
bug
Issue was opened via the bug report template.
labels
Nov 29, 2021
Related vercel/styled-jsx#736 |
10 tasks
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 17, 2022
This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another `2.75 MB`. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the `optionalDependencies` which is slowing down install time as well. x-ref: #32679 x-ref: #32627 x-ref: #31887 x-ref: vercel/styled-jsx#770
Resolved by #32742 , you can install latest canary ( |
NiGhTTraX
added a commit
to NiGhTTraX/ts-monorepo
that referenced
this issue
Jan 24, 2022
This reverts the workarounds for #159, #74 and #60, as they are no longer needed. There are a few peer dependency warnings, though the examples work just fine: - The one for NextJS is tracked in vercel/next.js#31887. - CRACO support for CRA@5 is tracked in dilanx/craco#378. - The warnings for CRA are tracked in facebook/create-react-app#11982, except for the `ts-jest` one which is expected, since we're using CRA's `jest`.
natew
pushed a commit
to natew/next.js
that referenced
this issue
Feb 16, 2022
This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another `2.75 MB`. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the `optionalDependencies` which is slowing down install time as well. x-ref: vercel#32679 x-ref: vercel#32627 x-ref: vercel#31887 x-ref: vercel/styled-jsx#770
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Next.js are you using?
12.0.4
What version of Node.js are you using?
16.x
What browser are you using?
Chrome
What operating system are you using?
macOS
How are you deploying your application?
next dev
Describe the Bug
next > styled-jsx: @babel/plugin-syntax-jsx@7.14.5 requires a peer of @babel/core@^7.0.0-0 but none was installed.
package
next
requiresstyled-jsx
which has a unversioned optional peerDep@babel/core
, but styled-jsx also requires@babel/plugin-syntax-jsx
which has a required peerDep@babel/core
. Andnext
does not require@babel/core
.This ends up with
@babel/plugin-syntax-jsx
missed his peerDep@babel/core
.Although it works for now, but with
pnpm
, it will log warning like above, and I think for sure a clear dependency graph should be maintained.There are multiple solutions,
next
add@babel/core
as dependency, and mark@babel/core
as required peerDependency instyled-jsx
.next
add@babel/core
as peerDependency, and let user add@bable/core
in their own project.@babel/core
from@babel/plugin-syntax-jsx
(I had a look into this package, I am not really sure why did they add@babel/core
as its peerDep)Expected Behavior
Clear dependency.
To Reproduce
No need.
The text was updated successfully, but these errors were encountered: