-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge refactor #309
Huge refactor #309
Conversation
Awesome @zStupan! Your commit looks brilliant. We are now just step away from v 2.0. Please give me an answer on two additional questions (so that we can track changes easily).
|
Regarding the docstrings, I will enhance tests with interrogate package: https://github.com/econchick/interrogate It may be very helpful for us. What do you think? |
@zStupan - I forgot to say thank you for your time and effort. 👍 |
@firefly-cpp No problem. Regarding Tasks, attribute names were changed, and the methods for getting lower, upper, range, iters and evals were removed as they can be accessed as attributes. They should work as expected. Interrogate seems like a great addition. |
@GregaVrbancic any comments from your side? Otherwise, we can merge to master. |
@zStupan Great job, huge enhancement. Many thanks. Respect. |
Thank you for the effort in the project, @zStupan. I could see the summary changes you mentioned in the commits referred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes would benefit the current project structure by removing unneeded nested repeated package names.
It looks perfect to me. Superb job @zStupan! |
@all-contributors please add @zStupan as for doc, example and test contributor |
I've put up a pull request to add @zStupan! 🎉 |
Summary
get_algorithm
andget_benchmark
in niapy.util.factory.Remaining problems:
I'm sorry it took so long 😅