Status page transmitter days highlighted depending on the number of days #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navid200
changed the title
Navid200
changed the title
jamorham
reviewed
Jun 1, 2022
| @@ -2111,7 +2112,14 @@ public void run() { | |||
| l.add(new StatusItem("Transmitter Status", battery_status, BAD)); | |||
| } | |||
|
|
|||
| l.add(new StatusItem("Transmitter Days", parsedBattery.daysEstimate())); | |||
| if (vr != null && (FirmwareCapability.isTransmitterRawCapable(getTransmitterID())) || DexTimeKeeper.getTransmitterAgeInDays(tx_id) < 69) { | |||
There was a problem hiding this comment.
There is a lot of code duplication here.
Can't you just pull the age in to a local variable and assign another variable for the highlight color based on which conditions are met and then add the status item a single time with the computed highlight?
There was a problem hiding this comment.
Yes, thanks. I will do that.
There was a problem hiding this comment.
I have made the changes you suggested.
Please tell me if anything else can be improved.
Thanks
jamorham
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transmitter days line on the system status page (for Dexcom) is highlighted if the transmitter is not resettable depending on how many days are left to the end of life.
If transmitter days is less than 69, or if the transmitter is resettable, the Transmitter Days line will be as is now.
Only if the transmitter is Firefly and is not modified, the color will change when the transmitter days is greater than 68.
This serves as a reminder for the user to plan to order the next transmitter and plan the timing of the following sensors accordingly if the user intends to maximize the number of days they can use the transmitter.
It also highlights when no more sensors can be started.
This PR addresses the number 1 item from the three items identified here:
#2143 (comment)
I will open another PR shortly to address 2 from the same list.