fix: PyGithub 1.58+ support #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - fix Mypy issues - improve packaging by adding classifiers
|
Thanks @BoboTiG 🙌 |
Merged
|
Actually I got one small follow up question: Did anything prevent you from using the current version of python-github-bot-api with PyGithub 1.58+? |
|
Released in 0.5.2 |
Yes, it wasn't possible at all given the |
|
Ah yes of course, you did mention that in the test. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a patch to support PyGithub 1.58+, fix mypy issues, and also improve packaging checks by adding classifiers.
I also fixed
slap run fmt, and actually run the command. It explains the number of changes. I did it in a separate commit to ease the review.