Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution.Nixpkgs.Haskell.FromCabal: no longer emit dep on webkitgtk24x #521

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Distribution.Nixpkgs.Haskell.FromCabal: no longer emit dep on webkitgtk24x #521

merged 3 commits into from
Sep 28, 2021

Commits on Sep 28, 2021

  1. Distribution.Nixpkgs.Haskell.FromCabal: don't depend on webkitgtk24x 

    webkitgtk24x-gtk{2,3} have been removed from nixpkgs a while ago and
only continue to exist as aliases which throw, informing about the
removal. This is informative, but depends on evaluating with aliases
enabled which may not always be the case.

Instead we just remove this now essentially useless code from
cabal2nix. This will usually cause a dependency on the current version
of webkitgtk and the build to fail -- then we can mark the resulting
package as broken normally which was prevented before by eval
oddities (I presume at least).
    @sternenseemann
    sternenseemann committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    fb8fd9d View commit details
    Browse the repository at this point in the history

  2. Distribution.Nixpkgs.Haskell.FromCabal.Name: webkit -> webkitgtk 

    This reflects nixpkgs where webkit is an alias for webkitgtk.
    @sternenseemann
    sternenseemann committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    bcda928 View commit details
    Browse the repository at this point in the history

  3. CHANGELOG: document changed behavior wrt webkitgtk24x-*

    @sternenseemann
    sternenseemann committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e825974 View commit details
    Browse the repository at this point in the history