Update towards-reproducibility-pinning-nixpkgs.md #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fricklerhandwerk
approved these changes
Aug 13, 2024
source/tutorials/first-steps/towards-reproducibility-pinning-nixpkgs.md
Outdated
Show resolved
Hide resolved
|
Yeah, makes sense. Thanks! |
source/tutorials/first-steps/towards-reproducibility-pinning-nixpkgs.md
Outdated
Show resolved
Hide resolved
fricklerhandwerk
force-pushed
the
patch-3
branch
from
4985371
to
5651b47
Compare
I expected the `<nixpkgs>` link to point to a resource that explains what that construct is and not directly to Nixpkgs. If I would be totally new to Nix, that would be even more confusing. Couldn't test whether the links in the new note section resolve properly as MyST wouldn't compile on my Mac M1. If you you like this change, I can spend more time to test them properly.
fricklerhandwerk
force-pushed
the
patch-3
branch
from
5651b47
to
f9c7d59
Compare
fricklerhandwerk
force-pushed
the
patch-3
branch
from
972da17
to
ff914a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expected the
<nixpkgs>link to point to a resource that explains what that construct is and not directly to Nixpkgs. If I would be totally new to Nix, that would be even more confusing.Couldn't test whether the links in the new note section resolve properly as MyST wouldn't compile on my Mac M1. If you you like this change, I can spend more time to test them properly.