Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the follows of a transitive input without overriding its flakeref #8325

Open
edolstra opened this issue May 12, 2023 · 3 comments
Assignees

Comments

@edolstra
Copy link
Member

Describe the bug

E.g. an override like

inputs.foo.inputs.bar.inputs.nixpkgs.follows = "nixpkgs";

implicitly sets inputs.foo.inputs.bar to flake:bar, leading to an unexpected error like

error: cannot find flake 'flake:bar' in the flake registries

Expected behavior

The original flakeref for the bar input in foo's flake.nix should be respected.

nix-env --version output

2.16.0

Priorities

Add 👍 to issues you find important.

@Kha
Copy link
Contributor

Kha commented May 12, 2023

This looks like a duplicate of #5790. I just checked that #6621 applies cleanly to both current master and lazy-trees. I haven't rerun the tests yet though.

@gilice
Copy link
Member

gilice commented May 16, 2023

Probably also related to #6986

@citriqa
Copy link

citriqa commented May 25, 2023

@Kha it just applies cleanly because that's a noop, since it's already & still applied. a revert cannot be undone be re-applying - easy to overlook (and git of course doesn't mention that the action had no effect...)
my attempt to un-revert in the lazy-trees branch unfortunately resulted in a strange boehm-gc allocation failure that i haven't yet figured out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants