Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand frame traces #8906

Open
3 tasks
roberth opened this issue Sep 3, 2023 · 0 comments
Open
3 tasks

Understand frame traces #8906

roberth opened this issue Sep 3, 2023 · 0 comments
Assignees
Labels
error-messages Confusing messages and better diagnostics language The Nix expression language; parser, interpreter, primops, evaluation, etc tests

Comments

@roberth
Copy link
Member

roberth commented Sep 3, 2023

This issue is somewhat of a personal note while I work on traces every now and then. Gathering knowledge here helps me and possibly others until the "problem" is solved.

Is your feature request related to a problem? Please describe.

Frame traces are a mystery to me, and presumably others.

Their use has expanded around the time we unreversed the stack trace printing order. I suspect something about these changes might interact wrong.

I've had to remove the stop after frame logic to get some things to print in

Describe the solution you'd like

  • Make frame traces more explicit in the code. greppable. Refactor it to use a recognizable identifier instead of a positional bool.
  • Add tests to cover the apparent intent of each frame trace and make changes observable.
  • Make changes and see whether the traces improve. I expect they will.

Describe alternatives you've considered

N/A.

Additional context

Priorities

Add 👍 to issues you find important.

@roberth roberth added error-messages Confusing messages and better diagnostics language The Nix expression language; parser, interpreter, primops, evaluation, etc tests labels Sep 3, 2023
@roberth roberth self-assigned this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error-messages Confusing messages and better diagnostics language The Nix expression language; parser, interpreter, primops, evaluation, etc tests
Projects
None yet
Development

No branches or pull requests

1 participant