Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capabilities of the build machine leak into the manpage #9251

Closed
raboof opened this issue Oct 27, 2023 · 3 comments · Fixed by #9443
Closed

Capabilities of the build machine leak into the manpage #9251

raboof opened this issue Oct 27, 2023 · 3 comments · Fixed by #9443
Labels
bug documentation settings Settings, global flags, nix.conf

Comments

@raboof
Copy link
Member

raboof commented Oct 27, 2023

Describe the bug

On nix 2.17.1, the nix3-help-stores manpage contains:

       •  system-features

          Optional  features  that  the  system this store builds on implements
          (like “kvm”).

          Default: benchmark big-parallel kvm nixos-test uid-range

However, the Default: line shows the features the system that produced the manpage implements, which might not be same as the features the system this store builds on implements.

This is not only slightly confusing, but means this output is not reproducible, impacting for example the reproducibility of the minimal installation ISO.

This also affects the doc output

Steps To Reproduce

nix-build '<nixpkgs>' -A nix.man --check on a machine that supports different features than Hydra.

Expected behavior

--check succeeds

Priorities

Add 👍 to issues you find important.

@raboof raboof added the bug label Oct 27, 2023
@raboof
Copy link
Member Author

raboof commented Oct 27, 2023

Could someone with write access to the repo add this issue to the 'Reproducible Builds' GitHub project, with state 'Minimal ISO runtime'?

@cole-h
Copy link
Member

cole-h commented Oct 27, 2023

Could someone with write access to the repo add this issue to the 'Reproducible Builds' GitHub project, with state 'Minimal ISO runtime'?

Done! (FWIW: this only required triage, not write)

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-reproducible-builds-minimal-installation-iso-successfully-independently-rebuilt/34756/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation settings Settings, global flags, nix.conf
Projects
Status: Minimal ISO runtime
Development

Successfully merging a pull request may close this issue.

4 participants