Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect reference to NIX_PATH documentation #7514

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

fricklerhandwerk
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk commented Dec 26, 2022

the semantics are not explained in the referenced section any more.
they have been moved to the documentation for common options in the new CLI in #7421.

unfortunately I was under the incorrect impression that there was only one source for the documentation of common options, so in fact the change made discoverability of that piece of documentation strictly worse.

while I know that de facto the classic command line is not maintained any more, I still suggest to fix that properly. who knows how long it will be around...

This work is sponsored by Antithesis

@roberth
Copy link
Member

roberth commented Jan 6, 2023

Prefer to merge after

  • rebase?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-01-06-nix-team-meeting-minutes-21/24573/1

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, and maybe avoid footnote-like syntax in snippets?

@roberth
Copy link
Member

roberth commented Jan 14, 2023

Needs a rebase, and maybe avoid footnote-like syntax in snippets?

GitHub ate my file comment 😠

Basically I was asking whether footnote-like link syntax is robust enough for snippets, considering that the reference names may collide.

@fricklerhandwerk
Copy link
Contributor Author

whether footnote-like link syntax is robust enough for snippets

Good point, actually.

the semantics are not explained in the referenced section any more, they
have been moved to the documentation for common options in the new CLI [0].

[0]: 703d863
@fricklerhandwerk fricklerhandwerk changed the title remove incorrect reference, fix links remove incorrect reference to NIX_PATH documentation Apr 5, 2023
@fricklerhandwerk
Copy link
Contributor Author

@roberth things fixed themselves underneath, rebased. Now this PR is as tiny as it should be.

Co-authored-by: John Ericson <git@JohnEricson.me>
@fricklerhandwerk fricklerhandwerk merged commit 39e0f60 into NixOS:master Apr 17, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-04-17-nix-team-meeting-minutes-49/27379/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants