Trivial changes from the lazy-trees branch #7421
Conversation
edolstra
requested review from
fricklerhandwerk and
thufschmitt
as code owners
edolstra
force-pushed
the
lazy-trees-trivial-changes
branch
2 times, most recently
from
28f1120
to
6c2652a
Compare
edolstra
force-pushed
the
lazy-trees-trivial-changes
branch
from
6c2652a
to
703d863
Compare
There was a problem hiding this comment.
Moving the NIX_PATH documentation to the -I section is great, because once we append the common options section to all the old command reference, people will finally be able to find that documentation on their own.
NIX_PATH has been confusing the hell out of people for many years, and I suspect more than half of that was due to the relevant documentation being so hard to discover.
There was a problem hiding this comment.
Thanks for that, it's already more digestible to me than #6530 :)
Left a bunch of small comments here and there for the various changes, but looks good overall
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-41/23848/1 |
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
edolstra
dismissed stale reviews from thufschmitt and fricklerhandwerk
Most suggestions applied.
The description for commandline falgs is used as an annotation for commandline completions. These descriptions may *not* include any newline characters. This line was changed by NixOS#7421 and breaks `nix` commandline completions for any commandline flags.
The description for commandline flags is used as an annotation for commandline completions. These descriptions may *not* include any newline characters. This line was changed by NixOS#7421 and breaks `nix` commandline completions for any commandline flags.
No description provided.