Fix the coverage job #7686
Merged
Fix the coverage job #7686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
added
the
backport 2.13-maintenance
edolstra
reviewed
Jan 25, 2023
| @@ -465,6 +465,10 @@ | |||
|
|
|||
| src = self; | |||
|
|
|||
| configureFlags = [ | |||
| "CXXFLAGS=-I${lib.getDev pkgs.rapidcheck}/extras/gtest/include" | |||
There was a problem hiding this comment.
Why do we pass this as a configure flag? Why not NIX_CFLAGS_COMPILE?
There was a problem hiding this comment.
@edolstra It could work either way, but I think this is a bit nicer because it documents how one would do things without a cc-wrapper on other platforms.
I generally think of the cc-wrapper vars a last sort, and it being better to leverage a project's build system than sneak behind its back.
I opened emil-e/rapidcheck#302 in hope that rapidcheck would be OK with having a pkg-config file, and then all this can just go away.
Ericson2314
removed
the
backport 2.13-maintenance
|
Removed backport label because with #7687 2.13 no longer depends on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://hydra.nixos.org/build/206790960
Context
More motivation for #6538 and #7674 to help us avoid regressions like these in the future.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/tests