Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the coverage job #7686

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix the coverage job #7686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,10 @@

src = self;

configureFlags = [
"CXXFLAGS=-I${lib.getDev pkgs.rapidcheck}/extras/gtest/include"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we pass this as a configure flag? Why not NIX_CFLAGS_COMPILE?

Copy link
Member Author

@Ericson2314 Ericson2314 Jan 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edolstra It could work either way, but I think this is a bit nicer because it documents how one would do things without a cc-wrapper on other platforms.

I generally think of the cc-wrapper vars a last sort, and it being better to leverage a project's build system than sneak behind its back.

I opened emil-e/rapidcheck#302 in hope that rapidcheck would be OK with having a pkg-config file, and then all this can just go away.

];

enableParallelBuilding = true;

nativeBuildInputs = nativeBuildDeps;
Expand Down