Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure.ac rapidcheck tests #7718

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

Ericson2314
Copy link
Member

Motivation

  • AC_LANG_PUSH(C++) is needed for the header check

  • The library check is hopeless (without lots of third-party macros I don't feel like getting) because name mangling

Context

Pkg-config would make all this easier. I previously opened emil-e/rapidcheck#302, I should write a PR too.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes

- `AC_LANG_PUSH(C++)` is needed for the header check

- The library check is hopeless (without lots of third-party macros I
  don't feel like getting) because name mangling

Pkg-config would make all this easier. I previously opened
emil-e/rapidcheck#302, I should write a PR
too.
@edolstra edolstra merged commit ed9d7c8 into NixOS:master Feb 1, 2023
@Ericson2314 Ericson2314 deleted the fix-rapidcheck-autoconf branch February 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants