Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libexpr: add missing dependency on 'flake/call-flake.nix.gen.hh' #9462

Merged
merged 2 commits into from
Nov 27, 2023
Merged

libexpr: add missing dependency on 'flake/call-flake.nix.gen.hh' #9462

merged 2 commits into from
Nov 27, 2023

Commits on Nov 27, 2023

  1. libexpr: add missing dependency on 'flake/call-flake.nix.gen.hh' 

    Without the change build for `eval.o` fails occasionally as:

    $ make src/libexpr/eval.o
      GEN    Makefile.config
      GEN    src/libexpr/primops/derivation.nix.gen.hh
      GEN    src/libexpr/fetchurl.nix.gen.hh
      GEN    src/libexpr/parser-tab.cc
      GEN    src/libexpr/lexer-tab.cc
    src/libexpr/lexer.l:314: warning, -s option given but default rule can be matched
      CXX    src/libexpr/eval.o
    src/libexpr/eval.cc:519:18: fatal error: flake/call-flake.nix.gen.hh: No such file or directory
      519 |         #include "flake/call-flake.nix.gen.hh"
          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    compilation terminated.
    make: *** [mk/patterns.mk:3: src/libexpr/eval.o] Error 1

Noticed in NixOS/nixpkgs#269439
    @trofi
    trofi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    75134b7 View commit details
    Browse the repository at this point in the history

  2. libexpr/local.mk: Make eval compile deps regular 

    Dependency is now entirely through the eval.cc rule.
All gen.hh deps are now there.
    @roberth
    roberth committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    68c4875 View commit details
    Browse the repository at this point in the history