libexpr: add missing dependency on 'flake/call-flake.nix.gen.hh' #9462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the change build for `eval.o` fails occasionally as:
$ make src/libexpr/eval.o
GEN Makefile.config
GEN src/libexpr/primops/derivation.nix.gen.hh
GEN src/libexpr/fetchurl.nix.gen.hh
GEN src/libexpr/parser-tab.cc
GEN src/libexpr/lexer-tab.cc
src/libexpr/lexer.l:314: warning, -s option given but default rule can be matched
CXX src/libexpr/eval.o
src/libexpr/eval.cc:519:18: fatal error: flake/call-flake.nix.gen.hh: No such file or directory
519 | #include "flake/call-flake.nix.gen.hh"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [mk/patterns.mk:3: src/libexpr/eval.o] Error 1
Noticed in NixOS/nixpkgs#269439
Merged
13 tasks
roberth
added
the
backport 2.19-maintenance
Dependency is now entirely through the eval.cc rule. All gen.hh deps are now there.
roberth
approved these changes
Nov 27, 2023
|
The |
|
Successfully created backport PR for |
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
libexpr: add missing dependency on 'flake/call-flake.nix.gen.hh' (cherry picked from commit f018048) Change-Id: I27211872ad75034ae3f04e18b2987f9968073d00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change build for
eval.ofails occasionally as:Noticed in NixOS/nixpkgs#269439
Motivation
Context
Priorities
Add 👍 to pull requests you find important.