Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No binary for v0.6.0 release? #139

Closed
edslocomb opened this issue Oct 31, 2023 · 6 comments
Closed

No binary for v0.6.0 release? #139

edslocomb opened this issue Oct 31, 2023 · 6 comments

Comments

@edslocomb
Copy link

Hi, I've been working on an emacs package, Apheleia, that supports nixfmt.

For testing, it's awfully convenient to just download a binary without having to install Nix on the CI server. v0.5.0 had a binary, v0.6.0 does not-- is there any chance that could be added?

@infinisil
Copy link
Member

I'm not sure how the previous static binary was created, there's no Nix setup for that. @yorickvP you did the previous release, how did you generate that? https://github.com/serokell/nixfmt/releases/tag/v0.5.0

@Lucus16
Copy link
Contributor

Lucus16 commented Nov 1, 2023 via email

@infinisil
Copy link
Member

@Lucus16 The release artifacts include a static binary, but no Flake output produce that (not even nixfmt-static)

@yorickvP
Copy link
Contributor

yorickvP commented Nov 1, 2023

I don't remember, but presumably I built pkgsStatic.nixfmt-static

@infinisil
Copy link
Member

Nice that worked, I tried that out before but was worried it was gonna rebuild too much, turns out it's not too much.

@edslocomb Release now contains a static binary: https://github.com/serokell/nixfmt/releases/tag/v0.6.0 :)

@edslocomb
Copy link
Author

awesome, thanks!

edslocomb added a commit to edslocomb/apheleia that referenced this issue Nov 4, 2023
There was initially no binary available when nixfmt was updated,
but the devs there were kind enough to provide one:

NixOS/nixfmt#139
raxod502 pushed a commit to radian-software/apheleia that referenced this issue Nov 12, 2023
This also fixes a few test installers:

- rustfmt is available via apt-get in 22.04, use that instead of tarball
that's no longer available
- brittany now installs cleanly in the default haskell ghc/cabal in
22.04, so just use that
- perltidy in 22.04 has slightly different output
- nixfmt download url changed (now includes OS/arch). There was
initially no binary available when nixfmt was updated,
but the devs there were kind enough to provide one:
NixOS/nixfmt#139

This runs a full `make fmt-build` without errors, though it takes a
while ;). All tests pass, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants