Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: drop hardware.amdgpu.amdvlk option #977

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jun 13, 2024

Description of changes

This is now provided in nixpkgs (see NixOS/nixpkgs#318175).

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Mic92
Copy link
Member

Mic92 commented Jun 13, 2024

We have users of both unstable and stable that use nixos-hardware. To drop it in nixos-hardware, we also need a backport of the module.

@pbsds
Copy link
Member

pbsds commented Jun 13, 2024

To not have change in behavior i think this PR needs a

hardware.amdgpu.amdvlk.support32Bit.enable = lib.mkDefault config.hardware.amdgpu.amdvlk.enable;

EDIT: never mind, hardware.amdgpu.amdvlk = true is an eval error

@Mic92
Copy link
Member

Mic92 commented Jun 13, 2024

Can be merged once we have NixOS/nixpkgs#319510 merged.

@Mic92
Copy link
Member

Mic92 commented Jun 13, 2024

Unfortunately there is no nixpkgs tracker support for stable releases. So we have to check manually when NixOS/nixpkgs#319510 lands.

@JohnRTitor
Copy link
Contributor

Perhaps https://nixpk.gs/pr-tracker.html?pr=319510 can help with that.

@DrymarchonShaun
Copy link

I believe this is in 24.05 now? Just tried to update my 24.05 system, and now I'm getting the error mentioned in #979

@Mic92 Mic92 merged commit 239c386 into NixOS:master Jun 15, 2024
2 checks passed
caspervk added a commit to caspervk/nixos that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants