Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added header and some other stuff to Astro rework #1127

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Added header and some other stuff to Astro rework #1127

merged 7 commits into from
Sep 21, 2023

Conversation

thilobillerbeck
Copy link
Collaborator

@thilobillerbeck thilobillerbeck commented Sep 19, 2023 •
edited by garbas
Loading

This branch adds:

  • a reimplementation of the page header in Tailwind (animation currently not working)
  • a more DRY footer and some layout components
  • stored menu data in content folder and query it in components
  • SVGs imported as proper images instead of inlining

ref #1125

@garbas
Copy link
Member

garbas commented Sep 20, 2023

Let's first merge #1126 to get CI green and then merge it also here. @thilobillerbeck @tfc have some time to review it?

@github-actions
Copy link
Contributor

🚀 Deployed on https://650b6c26ed4b5358143efaf7--nixos-homepage.netlify.app

@tfc
Copy link
Contributor

tfc commented Sep 21, 2023

Looks awesome!

garbas
garbas approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@garbas garbas merged commit a535747 into main Sep 21, 2023
2 checks passed
@garbas garbas deleted the astro/header branch September 21, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

@tfc tfc Awaiting requested review from tfc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thilobillerbeck @garbas @tfc