Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakes: add lnbits-legend #510

Merged
merged 2 commits into from
Dec 29, 2022
Merged

flakes: add lnbits-legend #510

merged 2 commits into from
Dec 29, 2022

Conversation

MatthewCroughan
Copy link
Contributor

This adds a project I've encouraged to use Flakes and Nix called "lnbits", to the searchable registry on search.nixos.org.

@ncfavier
Copy link
Member

services.lnbits.package needs a defaultText.

@MatthewCroughan
Copy link
Contributor Author

@ncfavier I've done what you suggested, so does this now look good to merge?

@ncfavier
Copy link
Member

ncfavier commented Aug 3, 2022

Sure, although I'm not entirely sure whether we want to welcome cryptocurrency-related projects into the Nix ecosystem, so I'll leave the decision to somebody else.

@MatthewCroughan
Copy link
Contributor Author

@ncfavier There are already numerous, such as nix-bitcoin in the index. So you'll have to remove those too if you're going to make such a decision, otherwise what you have said is quite unfair.

@MatthewCroughan
Copy link
Contributor Author

@jonasnick is the author of nix-bitcoin which is already included in the nixos-search index.

@MatthewCroughan
Copy link
Contributor Author

@ncfavier If you want to ban cryptocurrency related projects from nixos-search, please add that to #486.

@erikarvstedt
Copy link
Member

@ncfavier, what's the rationale for banning cryptocurrency projects from the Nix ecosystem?

One of the Flake design goals is a broadened, not a narrowed scope compared to nixpkgs, so shouldn't cryptocurrencies be banned from nixpkgs and NixOS first?

Tweag, the largest commercial actor in the nix ecosystem, is strongly associated with cryptocurrencies (i.e. Cardano and Tezos). How is this compatible with banning cryptocurrencies from Nix?

@ysndr ysndr added the blocked Blocked for Merge label Sep 7, 2022
@Mic92
Copy link
Member

Mic92 commented Dec 29, 2022

I am ok with merging this when merge conflicts are resolved.

@Mic92 Mic92 merged commit 24bdbc9 into NixOS:main Dec 29, 2022
@MatthewCroughan MatthewCroughan deleted the mc/add-lnbits branch December 29, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked for Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants