Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated Nixpkgs update #14

Closed
wants to merge 1 commit into from
Closed

Automated Nixpkgs update #14

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

Update the pinned Nixpkgs automatically

@philiptaron
Copy link
Contributor

Things I wish:

  1. Of the packages we use,
  2. Did any of them update,
  3. And what were the changes?

I wish this about nix flake update --commit-lock-file too.

With nixpkgs in particular, there's a lot of metadata to mine that would make this a gorgeous "hell yes" or "hell no" moment.

philiptaron
philiptaron approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's unleash the CI at it.

@infinisil
Copy link
Member

Oh there's this problem where PRs from workflows don't trigger workflows themselves 🤔

@philiptaron
Copy link
Contributor

philiptaron commented Mar 19, 2024 •
edited
Loading

Oh there's this problem where PRs from workflows don't trigger workflows themselves 🤔

Hrm. That's not copacetic.

I can kind of imagine the reasoning. It's really easy to make something that's an accidental fork-bomb of GitHub resources.

@philiptaron philiptaron mentioned this pull request Mar 19, 2024
Merged
@infinisil
Copy link
Member

Workarounds are listed here. I think using a separate machine account is probably the best one in our case.

@willbush
Copy link
Member

Should we setup dependabot also to update cargo dependencies?

@infinisil
Copy link
Member

Dependabot feels a bit too GitHub-centric, how about just adding a cargo update to the auto updates?

@infinisil infinisil mentioned this pull request Mar 21, 2024
Merged
@philiptaron
Copy link
Contributor

This guy is wedged. We'll unwedge something else.

philiptaron added a commit that referenced this pull request Mar 21, 2024
@philiptaron
Improve auto updates and welcome @infinixbot (#15)
0f556f9 
Improves upon the automated update PRs introduced in #12 to resolve issues brought up in the first automated PR #14.

* Give more information about the updates, not much, but at least the output of npins update
* Update all npins sources, not just Nixpkgs.
* Run `cargo update`
* Make it trigger CI by using an unprivileged separate machine account (welcome, @infinixbot!)
* Set committer and author of the commits to the machine account
@infinisil infinisil deleted the auto-nixpkgs-update branch March 21, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philiptaron @infinisil @willbush