Skip to content

Commit

Permalink
gcc: maintenance 5.3 -> 5.4
Browse files Browse the repository at this point in the history
  • Loading branch information
@vcunat
vcunat committed Jun 9, 2016
1 parent bd458e5 commit 772c92b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkgs/development/compilers/gcc/5/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ assert langGo -> langCC;
with stdenv.lib;
with builtins;

let version = "5.3.0";
let version = "5.4.0";
sha256 = "0fihlcy5hnksdxk0sn6bvgnyq8gfrgs8m794b1jxwd1dxinzg3b0";

# Whether building a cross-compiler for GNU/Hurd.
crossGNU = cross != null && cross.config == "i586-pc-gnu";
Expand Down Expand Up @@ -212,7 +213,7 @@ stdenv.mkDerivation ({

src = fetchurl {
url = "mirror://gnu/gcc/gcc-${version}/gcc-${version}.tar.bz2";
sha256 = "1ny4smkp5bzs3cp8ss7pl6lk8yss0d9m4av1mvdp72r1x695akxq";
inherit sha256;
};

inherit patches;
Expand Down

3 comments on commit 772c92b

@dezgeg
Copy link
Contributor

@dezgeg dezgeg commented on 772c92b Jun 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, after this some packages fail to find some math functions: http://hydra.nixos.org/eval/1278490#tabs-now-fail e.g. http://hydra.nixos.org/build/36774105/nixlog/1/raw

git bisect start
# bad: [1c6b534585fd89a3e64854bdd8978c35a2403aac] make-bootstrap-tools-cross.nix: Use tarMinimal as in non-cross version
git bisect bad 1c6b534585fd89a3e64854bdd8978c35a2403aac
# good: [b9d42f79c979489d678e99b0faa2fc6e0a8977dc] Merge recent master into staging
git bisect good b9d42f79c979489d678e99b0faa2fc6e0a8977dc
# bad: [46f22d89b94f6072153687dd50db1bee7c7bd34c] Merge #15867: glibc, gcc: fixes for ARM targets
git bisect bad 46f22d89b94f6072153687dd50db1bee7c7bd34c
# good: [89c9a8896b8b0793cdad1728c39e300bf10c5df7] same changes to the rest. 4.5 has inf recursion still, 4.6 too old for glibc2.23
git bisect good 89c9a8896b8b0793cdad1728c39e300bf10c5df7
# good: [89c9a8896b8b0793cdad1728c39e300bf10c5df7] same changes to the rest. 4.5 has inf recursion still, 4.6 too old for glibc2.23
git bisect good 89c9a8896b8b0793cdad1728c39e300bf10c5df7
# good: [89c9a8896b8b0793cdad1728c39e300bf10c5df7] same changes to the rest. 4.5 has inf recursion still, 4.6 too old for glibc2.23
git bisect good 89c9a8896b8b0793cdad1728c39e300bf10c5df7
# good: [cec03a8ecdd5f74f7bc258c0b8406e1e61dc6c9c] Merge #14753: makeWrapper: allow spaces in variables
git bisect good cec03a8ecdd5f74f7bc258c0b8406e1e61dc6c9c
# good: [bd458e56b6778cc7bbc2f076150657de574184da] Merge #14356: docbook updates
git bisect good bd458e56b6778cc7bbc2f076150657de574184da
# good: [fa4fcaf6b46af3fb4f0273bb657f96223763ac86] darwin output paths
git bisect good fa4fcaf6b46af3fb4f0273bb657f96223763ac86
# bad: [772c92ba5c60ab63694bdffbf847ed7434aa3142] gcc: maintenance 5.3 -> 5.4
git bisect bad 772c92ba5c60ab63694bdffbf847ed7434aa3142
# first bad commit: [772c92ba5c60ab63694bdffbf847ed7434aa3142] gcc: maintenance 5.3 -> 5.4

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 772c92b Jun 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least in case of rr they don't include <math.h> or <cmath> anywhere from that file, so it's just upstream bug that was hidden until now. I suggest we just patch the files to add the include; I did so for rr in e9c612c and d133a16.

I really dislike how the c(++) include system works, and actually the whole preprocessing phase...

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 772c92b Jun 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, all the missing includes should be resolved by 97c484a.

Please sign in to comment.