Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch stdenvs to pure-darwin #10187

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Switch stdenvs to pure-darwin #10187

merged 1 commit into from
Oct 14, 2015

Conversation

pikajude
Copy link
Contributor

@pikajude pikajude commented Oct 2, 2015

This is to go along with my ML message requesting a default stdenv switch to pure-darwin. The reactions have been positive so far!

@edolstra

@vcunat vcunat added 6.topic: darwin Running or building packages on Darwin 1.severity: mass-darwin-rebuild labels Oct 2, 2015
@domenkozar domenkozar mentioned this pull request Oct 2, 2015
@Ericson2314
Copy link
Member

Should we change the names to stdenvDarwin and stdenvDarwinImpure or something to reflect the new default?

@henrytill
Copy link
Member

👍

1 similar comment
@codedmart
Copy link
Contributor

👍

@acowley
Copy link
Contributor

acowley commented Oct 14, 2015

I already 👍 'd on the mailing list, but, just in case it can help un-wedge this, here's another 👍 !

It'd be great to get this ball rolling again.

pikajude pushed a commit that referenced this pull request Oct 14, 2015
Switch stdenvs to pure-darwin
@pikajude pikajude merged commit f4dbf6d into master Oct 14, 2015
@copumpkin
Copy link
Member

👍 👍 🍻 🍻

@benley
Copy link
Member

benley commented Oct 15, 2015

🏆 👍

@vcunat vcunat deleted the switch-to-pd branch October 15, 2015 07:31
@vcunat
Copy link
Member

vcunat commented Oct 15, 2015

You rejoice too early, as the stdenv won't build on Hydra. http://hydra.nixos.org/build/26728682

@datakurre
Copy link
Contributor

Does this require patches on top of Nix 1.10? Is NixOS/nix#562 enough? (From the build error it looks like that pull is required.)

@copumpkin
Copy link
Member

@copumpkin
Copy link
Member

I think Hydra needs a different nix.conf. Not sure how that sort of thing is managed!

@rbvermaa
Copy link
Member

@copumpkin what kind of changes does nix.conf need?

@edolstra
Copy link
Member

Note that the failing derivation (/nix/store/y3n191kgrrvc4r3rafz5hb919id8njs2-mkdir.drv) has system set to x86_64-linux, which I assume should be x86_64-darwin. Our Mac does not have sandbox builds enabled BTW.

@edolstra
Copy link
Member

This is probably due to:

pkgs/stdenv/pure-darwin/default.nix:{ system      ? builtins.currentSystem
pkgs/stdenv/pure-darwin/make-bootstrap-tools.nix:{system ? builtins.currentSystem}:

@edolstra
Copy link
Member

Now that pure-darwin is the default, should we get rid of the old darwin stdenv?

@pikajude
Copy link
Contributor Author

@edolstra I'd be fine with leaving it until Apple stops distributing Xcode 6, but the users need to be made aware it won't work on OSes newer than 10.9 or with Xcode 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: mass-darwin-rebuild 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.