Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ike-scan: init at 1.9.4 #107314

Merged
merged 1 commit into from
Jan 25, 2021
Merged

ike-scan: init at 1.9.4 #107314

merged 1 commit into from
Jan 25, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 21, 2020

Motivation for this change

ike-scan is a command-line tool that uses the IKE protocol to discover,
fingerprint and test IPsec VPN servers.

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff mentioned this pull request Dec 21, 2020
Merged
10 tasks
@fabaff
Copy link
Member Author

fabaff commented Dec 23, 2020

@ofborg eval

@fabaff
Copy link
Member Author

fabaff commented Dec 23, 2020

Result of nixpkgs-review pr 107314 run on x86_64-linux 1

1 package built:
  • ike-scan

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 23, 2020
@fabaff
Copy link
Member Author

fabaff commented Jan 16, 2021

Result of nixpkgs-review pr 107314 run on x86_64-linux 1

1 package built:
  • ike-scan

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/449

@fabaff
Copy link
Member Author

fabaff commented Jan 24, 2021

Result of nixpkgs-review pr 107314 run on x86_64-linux 1

1 package built:
  • ike-scan

@SuperSandro2000 SuperSandro2000 merged commit eccdb60 into NixOS:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @nixos-discourse @SuperSandro2000